Enable loading translated strings from razor TS code #5962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Jul 27, 2023
ryzngard
reviewed
Jul 27, 2023
ryzngard
reviewed
Jul 27, 2023
ryzngard
reviewed
Jul 27, 2023
ryzngard
approved these changes
Jul 27, 2023
|
I guess we might want to merge this after next Monday after the release? |
That makes sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable loading translated strings from razor TS code
This change wraps the many user displayed strings in the razor portion of the project wth l10n.t(''), using the format specifier {0} style where necessary. reportIssueCreator.ts is probably the single most interesting file.
Conversion from ${abc} to {0} syntax is the most likely area for issues.