This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Removing color from deployed app console logs #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiskRunner0
requested review from
davidfowl,
jkotalik and
rynowak
as code owners
|
|
…er, fixing test files to include new env variables
davidfowl
reviewed
Jul 14, 2020
| @@ -138,6 +141,9 @@ public static void ApplyContainerDefaults(ApplicationBuilder application, Docker | |||
| } | |||
|
|
|||
| container.ImageTag ??= "latest"; | |||
|
|
|||
| // Disable color in the logs | |||
| project.EnvironmentVariables.Add(new EnvironmentVariableBuilder("DOTNET_LOGGING__CONSOLE__DISABLECOLORS") { Value = "true" }); | |||
There was a problem hiding this comment.
This shouldn't be added for all docker files, just .NET projects.
There was a problem hiding this comment.
Ah yeah that's pretty obvious now, will fix
jkotalik
approved these changes
Jul 14, 2020
JunTaoLuo
approved these changes
Jul 14, 2020
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434