This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Implement cleanup command #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Apr 20, 2020
jkotalik
reviewed
Apr 20, 2020
jkotalik
reviewed
Apr 20, 2020
|
|
||
| `PATH` | ||
|
|
||
| The path to either a file or directory to execute `tye cleanup` on. Can either be a yaml, sln, or project file, however it is recommend to have a tye.yaml file for `tye cleanup`. |
There was a problem hiding this comment.
Consider allowing service name, so someone can delete everything associated with a service
tye delete frontend
There was a problem hiding this comment.
I don't want to do service name because I think that raises a lot of questions - and we don't have per-service deployment yet.
For instance, does it update the config of every other service to remove its env-vars? (Probably not).
Per-application cleanup is easier to reason about because things like secrets/bindings are shared. Basically we could support per-service cleanup, but then what happens? does the usage of it by other services just dangle?
There was a problem hiding this comment.
That seems well justified.
jkotalik
reviewed
Apr 20, 2020
|
|
||
| ## Examples | ||
|
|
||
| - Deploy an application from the current directory: |
There was a problem hiding this comment.
What do you mean fix? You mean update them when we decide on a command name?
jkotalik
reviewed
Apr 20, 2020
jkotalik
reviewed
Apr 20, 2020
jkotalik
reviewed
Apr 20, 2020
This is new command that can be used to delete everything running in a cluster related to an application using the labels we use. This currently uses a hardcoded set of resource types. It would be possible to make this generic, which might become needed in the future. See comments in the code. --- The overall design for how to use the command: ```sh tye cleanup ``` Will read a solution or tye.yaml to get the application name. It then enumerates and deletes all resources in the cluser with `app.kubernetes.io/part-of=application-name` (in the current namespace). ```sh tye cleanup --what-if ``` Will do the same, but without actually doing the deletion. ```sh tye cleanup -i ``` Will interactively give you a yes/no choice for whether to delete each resource.
Co-Authored-By: Justin Kotalik <jukotali@microsoft.com>
Co-Authored-By: Justin Kotalik <jukotali@microsoft.com>
rynowak
force-pushed
the
rynowak/cleanup
branch
from
ad3ece6
to
98ce6eb
Compare
kishanAnem
pushed a commit
to kishanAnem/tye
that referenced
this pull request
May 15, 2020
This is new command that can be used to delete everything running in a cluster related to an application using the labels we use. This currently uses a hardcoded set of resource types. It would be possible to make this generic, which might become needed in the future. See comments in the code. --- The overall design for how to use the command: ```sh tye undeploy ``` Will read a solution or tye.yaml to get the application name. It then enumerates and deletes all resources in the cluster with `app.kubernetes.io/part-of=application-name` (in the current namespace). ```sh tye undeploy --what-if ``` Will do the same, but without actually doing the deletion. ```sh tye undeploy -i ``` Will interactively give you a yes/no choice for whether to delete each resource.
kishanAnem
pushed a commit
to kishanAnem/tye
that referenced
this pull request
May 15, 2020
This is new command that can be used to delete everything running in a cluster related to an application using the labels we use. This currently uses a hardcoded set of resource types. It would be possible to make this generic, which might become needed in the future. See comments in the code. --- The overall design for how to use the command: ```sh tye undeploy ``` Will read a solution or tye.yaml to get the application name. It then enumerates and deletes all resources in the cluster with `app.kubernetes.io/part-of=application-name` (in the current namespace). ```sh tye undeploy --what-if ``` Will do the same, but without actually doing the deletion. ```sh tye undeploy -i ``` Will interactively give you a yes/no choice for whether to delete each resource.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is new command that can be used to delete everything running in a
cluster related to an application using the labels we use.
This currently uses a hardcoded set of resource types. It would be
possible to make this generic, which might become needed in the future.
See comments in the code.
The overall design for how to use the command:
Will read a solution or tye.yaml to get the application name. It then
enumerates and deletes all resources in the cluser with
app.kubernetes.io/part-of=application-name(in the current namespace).Will do the same, but without actually doing the deletion.
Will interactively give you a yes/no choice for whether to delete each
resource.