-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2.1.6 for respin #845
Conversation
@@ -3,7 +3,7 @@ | |||
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.props))/dir.props" /> | |||
|
|||
<PropertyGroup> | |||
<NuGetPackageVersion>2.3.2-beta1-61921-05</NuGetPackageVersion> | |||
<NuGetPackageVersion>2.10.0-beta2-63410-10</NuGetPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this has been affecting roslyn package version (anymore?). A build I did before this PR produced e.g. Microsoft.CodeAnalysis.CSharp.2.8.0
even though this was 2.3.2-beta1-61921-05
. Will comment here again with the version this PR ends up producing.
Doesn't seem like a problem because of forced auto-update, but we could get rid of this to be less misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, produces Microsoft.CodeAnalysis.CSharp.2.10.0
now.
Roslyn fails:
This update is over 3,000 commits! We missed some updates over time, it looks like. We're doing: Investigating. Worked around by disabling
and us using submodules. (And even if it worked with submodules, tarball build would have been even worse without any |
Works around issue with sourcelink usage.
Local build in progress to regen baselines if necessary.
New manifest: https://github.com/dotnet/versions/tree/c9bc176e798111c2ad9815cc1ef79b02ea9c8e94/build-info/dotnet/product/cli/release/2.1.6
CLI diff: dotnet/cli@14c7845...d5e54bf
MSBuild: Microsoft.Build/15.9.20
88f5fadf... in DLL 🙁
Roslyn: Microsoft.CodeAnalysis.CSharp/2.10.0-beta2-63410-10
45b3711... from nuspec 🙂