Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0.3xx] Update dependencies from microsoft/vstest #32755

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 23, 2023

This pull request updates the following dependencies

From https://github.com/microsoft/vstest

  • Subscription: c188d20e-29da-418d-2ccf-08daee6e84fe
  • Build: 20230606-04
  • Date Produced: June 6, 2023 12:50:16 PM UTC
  • Commit: 911a038b281705683d730f2ac48ce01328371e8a
  • Branch: refs/heads/rel/17.6

…230523-01

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.0-release-20230523-01
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CodeFlow untriaged Request triage from a team member labels May 23, 2023
@nohwnd
Copy link
Member

nohwnd commented May 23, 2023

This change contains a fix for "No suitable runtime provider found, that can happen when dlls that are using a runtime provider that is not supported are passed to the test run. E.g. when you select all dlls that contain test.dll in their name, you will provide some dlls that are part of TestPlatform and are .NETStandard, or part of MSTest and are .NET Portable. This is a regression in 17.6, which affects 7.0.3xx SDK.

microsoft/vstest#4474

@marcpopMSFT is this okay to merge without approval from .net tactics?

@nohwnd
Copy link
Member

nohwnd commented May 23, 2023

Even if okay, don't merge yet. Updating the branding on the branch, so we insert 17.6.1.

@marcpopMSFT
Copy link
Member

@nohwnd we just produced the candidate build for the June release so if possible, it'd be better if this can wait to be merged for July. CC @mmitche

@nohwnd
Copy link
Member

nohwnd commented May 24, 2023

Yes, sure. Thanks.

…230524-04

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.0-release-20230524-04
@dotnet-maestro
Copy link
Contributor Author

Notification for subscribed users from https://github.com/microsoft/vstest:

@cvpoienaru @MarcoRossignoli @Evangelink

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/microsoft/vstest) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

…230524-05

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.1-release-20230524-05
@nohwnd nohwnd removed untriaged Request triage from a team member DO NOT MERGE labels May 25, 2023
@nohwnd
Copy link
Member

nohwnd commented May 25, 2023

This is ready, please merge once the branch is open.

…230525-04

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.1-release-20230525-04
@marcpopMSFT
Copy link
Member

July should open for changes once branding goes in which should be on June 6th I believe. Adding back the do not merge label just so we don't accidentally merge early.

dotnet-maestro bot and others added 3 commits May 26, 2023 13:05
…230525-04

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.1-release-20230525-04
…230531-01

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.1-release-20230531-01
…230601-01

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.1
@nohwnd
Copy link
Member

nohwnd commented Jun 5, 2023

Downgrading Nuget.Frameworks here #4512

…230605-01

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.2-release-20230605-01
…230606-04

Microsoft.NET.Test.Sdk
 From Version 17.6.0-release-20230405-08 -> To Version 17.6.2
@v-wuzhai v-wuzhai merged commit 2fe8372 into release/7.0.3xx Jun 7, 2023
@v-wuzhai v-wuzhai deleted the darc-release/7.0.3xx-b2c5383e-7ef9-4a11-9895-24dea65b1414 branch June 7, 2023 09:39
@nohwnd
Copy link
Member

nohwnd commented Jun 7, 2023

For completeness two more PRs were merged into 17.6.2 which went in via this PR:

microsoft/vstest#4517
microsoft/vstest#4528

Those changes exclude know platform dlls from the run (e.g. Microsoft.TestPlatform.PlatformAbstractions.dll), because we know they don't have any tests, but they still get often provided by the user because they are using the default test.dll AzDO dll glob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants