[release/6.0.1xx] ResolveReadyToRunCompilers: map non-portable rids when targetOS is determined (backport #28380) #28782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…termined (backport dotnet#28380)
This was referenced Oct 26, 2022
|
CI is all green @ViktorHofer |
AntonLapounov
approved these changes
Nov 9, 2022
|
Note, as discussed in #28380, we want to backport this into release/7.0.1xx as well. |
ViktorHofer
approved these changes
Nov 9, 2022
|
hello @ayakael, thanks for porting to 6. Can this be ported to 7 as well? |
|
Here is the 7.0 backport #29052. |
mangod9
approved these changes
Nov 15, 2022
|
@ViktorHofer @AntonLapounov @mangod9 Could we please get this merged to unblock dotnet/installer#14816 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #28380
Per @tmds
Customer impact
Allows for flow of new RIDs that have yet to be added to runtime graph. This is important for distro maintainers as it is a maintainance headache to constantly have to manually update the runtime graph at every release.
Testing
Risk
Low, as it only activates when additional runtime RIDs are to be added