[release/7.0.1xx] Disable msbuild server by default #28369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AR-May
changed the title
rokonec
approved these changes
Oct 6, 2022
rainersigwald
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes MSBuild server an opt-in feature for 7.0 SDK, instead of opt-out. Given the recent failures in the dotnet/runtime repo when using this feature (dotnet/runtime#75391), we would like to have more time to fix the bugs and dogfood before it becomes an opt-out feature.
Customer Impact
Revert to 6.0-and-previous behavior, avoiding new instability (but not getting new perf improvements).
dotnet buildintroduced by the opt-out MSBuild Server feature.Regression?
Yes--server failed in some new cases.
Testing
Unit tests.
Risk
Low risk.
Description of the fix
We ignore DOTNET_CLI_DO_NOT_USE_MSBUILD_SERVER opt-out env. variable and use an opt-in DOTNET_CLI_USE_MSBUILD_SERVER env variable instead to control the MSBuild Server feature in SDK CLI.