Remove various timeouts #27699
Merged
Remove various timeouts #27699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkalyanms
approved these changes
Sep 6, 2022
mkArtakMSFT
reviewed
Sep 7, 2022
src/BuiltInTools/dotnet-watch/HotReload/BlazorWebAssemblyDeltaApplier.cs
Show resolved
Hide resolved
javiercn
reviewed
Sep 8, 2022
src/BuiltInTools/dotnet-watch/HotReload/BlazorWebAssemblyDeltaApplier.cs
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
While I don't have loads of context on this, I understand you're looking for someone on the Blazor team to approve, and it looks reasonable to me so approving.
It would be great to address @javiercn's comment if possible though.
tmat
force-pushed
the
Timeouts-Blazor
branch
from
91550d7
to
655d757
Compare
tmat
added a commit
to tmat/sdk
that referenced
this pull request
Sep 14, 2022
* Remove timeouts from BlazorWebAssemblyDeltaApplier * Remove timeout from delta applier. * Remove comment * Fail when capabilities can't be retrieved
tmat
added a commit
that referenced
this pull request
Sep 14, 2022
1 task
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion on dotnet/aspnetcore#40587 it appears that these timeouts are causing failures in real world usage of dotnet watch.
I don't think we should use arbitrary timeouts on these code paths as long as they are cancellable. If some communication gets stuck during Hot Reload for some reason the user can always trigger cancelation of the change application.
Fixes dotnet/aspnetcore#40587