Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0.1xx-rc1] Update dependencies from dotnet/runtime #27259

Merged
merged 3 commits into from
Aug 19, 2022
Merged

[release/7.0.1xx-rc1] Update dependencies from dotnet/runtime #27259

merged 3 commits into from
Aug 19, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 18, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: d09cde6c-2776-434a-f0f8-08da7ef63651
  • Build: 20220818.9
  • Date Produced: August 18, 2022 8:48:39 PM UTC
  • Commit: 08fdcb7e2d86292b529e7d662b691d8c86de678d
  • Branch: refs/heads/release/7.0-rc1

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
78437b0 
…0817.5

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22417.5
@jeffschwMSFT
Copy link
Member

@radical @lewing the partial failures are due to the wasm baseline tests: Expected subject to be a collection with 235 item(s), but found 247.

@lewing
Copy link
Member

lewing commented Aug 18, 2022

@TanayParikh time to pull in #27201 or disable the tests

@lewing
Copy link
Member

lewing commented Aug 18, 2022

I'd lean toward disabling since the list is likely to change again before rtm from things like dotnet/runtime#74165

@adityamandaleeka
Copy link
Member

@dougbu Can you please take a look? It looks like something is pulling in an incorrect version.

All the tests are failing on AspNetSdkBaselineTest.AssertManifest, similar to this:

    Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.JsModules_CanCustomizeBlazorInitialization [FAIL]
      Expected subject to be a collection with 229 item(s), but found 241.
      
With configuration:
- Use declared types and members
      - Compare enums by value
      - Match member by name (or throw)
      - Be strict about the order of items in byte arrays
      
      Stack Trace:
           at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
           at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
           at FluentAssertions.Execution.CollectingAssertionStrategy.ThrowIfAny(IDictionary`2 context)
           at FluentAssertions.Execution.AssertionScope.Dispose()
           at FluentAssertions.Equivalency.EquivalencyValidator.AssertEquality(EquivalencyValidationContext context)
           at FluentAssertions.AssertionExtensions.ShouldBeEquivalentTo[T](T subject, Object expectation, Func`2 config, String because, Object[] becauseArgs)
           at FluentAssertions.AssertionExtensions.ShouldBeEquivalentTo[T](T subject, Object expectation, String because, Object[] becauseArgs)
        /_/src/Tests/Microsoft.NET.Sdk.Razor.Tests/AspNetSdkBaselineTest.cs(359,0): at Microsoft.NET.Sdk.Razor.Tests.AspNetSdkBaselineTest.AssertManifest(StaticWebAssetsManifest manifest, StaticWebAssetsManifest expected, String suffix, String name)
        /_/src/Tests/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/WasmJsModulesIntegrationTests.cs(237,0): at Microsoft.NET.Sdk.BlazorWebAssembly.Tests.WasmJsModulesIntegrationTests.JsModules_CanCustomizeBlazorInitialization()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
           at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
      Output:
        > C:\h\w\A3DB08E0\p\d\dotnet.exe msbuild /t:Publish C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\blazorwasm-minimal.csproj /restore /bl
        MSBuild version 17.4.0-preview-22416-02+5d102ae37 for .NET
        C:\h\w\A3DB08E0\p\d\sdk\7.0.100-ci\MSBuild.dll -maxcpucount -verbosity:m /bl /restore /t:Publish C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\blazorwasm-minimal.csproj
          Determining projects to restore...
          Restored C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\blazorwasm-minimal.csproj (in 632 ms).
        C:\h\w\A3DB08E0\p\d\sdk\7.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(219,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\blazorwasm-minimal.csproj]
          blazorwasm-minimal -> C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\bin\Debug\net7.0\blazorwasm-minimal.dll
          blazorwasm-minimal (Blazor output) -> C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\bin\Debug\net7.0\wwwroot
          Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
          Optimizing assemblies for size. This process might take a while.
          Compressing Blazor WebAssembly publish artifacts. This may take a while...
          blazorwasm-minimal -> C:\h\w\A3DB08E0\t\dotnetSdkTests\y0c3nohb.2qa\JsModules_Can---FEE51C7C\bin\Debug\net7.0\publish\

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
d3f5fc7 
…0818.9

Microsoft.DotNet.ILCompiler , Microsoft.Extensions.DependencyModel , Microsoft.NET.HostModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , System.CodeDom , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages , VS.Redist.Common.NetCore.SharedFramework.x64.7.0 , VS.Redist.Common.NetCore.TargetingPack.x64.7.0
 From Version 7.0.0-rc.1.22411.12 -> To Version 7.0.0-rc.1.22418.9
@dougbu
Copy link
Member

dougbu commented Aug 18, 2022

@adityamandaleeka I don't know anything about the Blazor or WASM tests in this repo and don't understand why there may be new entries in the manifest. I'm hoping @captainsafia @javiercn @TanayParikh or @SteveSandersonMS have some context. If not, @dsplaisted or @marcpopMSFT may have some information.

@MackinnonBuck
Copy link
Member

I've just merged #27201 into #27149. Should I now cherry-pick those changes into this branch as well?

@dougbu
Copy link
Member

dougbu commented Aug 18, 2022

Should I now cherry-pick those changes into this branch as well?

If they apply, yes. And sorry for not including you in my loud scream for help 😉

@lewing
Copy link
Member

lewing commented Aug 18, 2022

@MackinnonBuck many thanks!

@lewing lewing enabled auto-merge (squash) August 19, 2022 02:04
@lewing lewing merged commit 20f30e0 into release/7.0.1xx-rc1 Aug 19, 2022
@lewing lewing deleted the darc-release/7.0.1xx-rc1-70c5f445-fab4-4e9b-b2dd-f3aca21b2771 branch August 19, 2022 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewing lewing lewing approved these changes

@captainsafia captainsafia Awaiting requested review from captainsafia

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

Assignees
No one assigned
Labels
Area-CodeFlow release blocking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeffschwMSFT @lewing @adityamandaleeka @dougbu @MackinnonBuck @TanayParikh