Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up native AOT testing #98939

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

MichalStrehovsky
Copy link
Member

We don't need to run analyzers on native AOT legs because they run on the same code elsewhere. Locally drops clr.aot+libs build from 5 mins 30 secs to 4 mins 45 secs.

Cc @dotnet/ilc-contrib

We don't need to run analyzers on native AOT legs because they run on the same code elsewhere. Locally drops `clr.aot+libs` build from 5 mins 30 secs to 4 mins 45 secs.
@ghost
Copy link

ghost commented Feb 26, 2024

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

We don't need to run analyzers on native AOT legs because they run on the same code elsewhere. Locally drops clr.aot+libs build from 5 mins 30 secs to 4 mins 45 secs.

Cc @dotnet/ilc-contrib

Author: MichalStrehovsky
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Feb 26, 2024

cc @dotnet/area-infrastructure-libraries

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we change the default locally as well?

@MichalStrehovsky
Copy link
Member Author

LGTM. Should we change the default locally as well?

Do you mean whether building clr.aot specifically should disable analyzers or whether to disable it for the whole product locally?

If it's 1, I would prefer us to be consistent with the rest of the product. Doing this on specific CI legs is just a perf optimization (we might have more legs where this could save time without impacting anything). Disabling analyzers locally for the whole product is the same discussion we had about disabling warnaserror locally. Some people had strong feelings about it. I disable warnaserror locally with an environment variable. I might end up doing the same for analyzers because their cost to my inner loop doesn't justify what they do; they usually just get in my way.

@agocke
Copy link
Member

agocke commented Feb 26, 2024

I think it makes sense to make most, if not all, analyzers run only in a separate pipeline built specifically for that purpose.

I'm fine with this specific change as well.

@MichalStrehovsky
Copy link
Member Author

I think it makes sense to make most, if not all, analyzers run only in a separate pipeline built specifically for that purpose.

I explored this in the past (for the warnaserror - so that we don't fail all pipelines if there's a warning) and my main concern was that because we have so many ifdefs, it would be difficult to ensure we don't introduce holes by accident. There's a big matrix between supported OSes, architectures, and build types. I know Roslyn sets up the build that way, but Roslyn probably doesn't have so many ifdefs :(

@MichalStrehovsky MichalStrehovsky merged commit 67a52a1 into dotnet:main Feb 26, 2024
178 of 180 checks passed
@MichalStrehovsky MichalStrehovsky deleted the fasterbuild branch February 26, 2024 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants