Update DiagnosticSourceUsersGuide.md #98801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix doc issues raised in #98499
ghost
assigned 
tarekgh
approved these changes
Feb 22, 2024
davmason
approved these changes
Feb 23, 2024
noahfalk
added a commit
to dotnet/docs
that referenced
this pull request
Feb 24, 2024
Porting the change in dotnet/runtime#98801 Calling out that DiagnosticListener may receive events that don't satisfy the provided filter.
noahfalk
added a commit
to dotnet/docs
that referenced
this pull request
Feb 24, 2024
Porting the change in dotnet/runtime#98801 Calling out that DiagnosticListener may receive events that don't satisfy the provided filter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix doc issues raised in #98499
DiagnosticListener can send events that don't satisfy the filter. This is non-obvious behavior so the docs should call it out.
There was some funky guidance about naming of payload types that conflicts with our standard namespace naming guidelines so I removed it.
@dotnet/dotnet-diag @tarekgh - does this look good?