Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Windows runs of AddressSanitizer #95758

Merged
merged 11 commits into from
Jan 30, 2024
Merged

Enable Windows runs of AddressSanitizer #95758

merged 11 commits into from
Jan 30, 2024

Conversation

jkoritzinsky
Copy link
Member

We now have a new enough version of VS for this

@ghost
Copy link

ghost commented Dec 7, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

We now have a new enough version of VS for this

Author: jkoritzinsky
Assignees: -
Labels:

area-Infrastructure
Milestone: -

@ghost ghost assigned jkoritzinsky Dec 7, 2023
@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Dec 7, 2023
Closed
Closed
@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 18, 2024
Closed
Closed
Closed
Closed
@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jan 18, 2024
Closed
Closed
Closed
@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jan 27, 2024
Closed
@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

Most of the libraries failures on Windows are due to #96035.

@jkoritzinsky
Copy link
Member Author

/azp run runtime-sanitized

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky jkoritzinsky requested a review from a team January 30, 2024 03:46
agocke
agocke approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from failures around the XUnitLogChecker. Looks like we might need to condition that again

eng/pipelines/runtime-sanitized.yml
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
buildConfig: Debug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Debug make a difference? That is, is asan supported in Release? Is it better/worse?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASAN is supported in release, but it can miss some checks as the instrumentation pass runs after many optimization passes, which can cause false negatives on some of the stack usage validation.

@build-analysis build-analysis bot mentioned this pull request Jan 30, 2024
Closed
@jkoritzinsky
Copy link
Member Author

The XUnitLogChecker failures are tracked by the issue I linked above (same underlying issue in both scenarios).

@jkoritzinsky jkoritzinsky merged commit a258bb9 into main Jan 30, 2024
185 of 191 checks passed
@ViktorHofer ViktorHofer deleted the asan-win branch January 30, 2024 08:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agocke agocke agocke approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @agocke