Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Split the informational version on both SemVer2 separators when calculating TFM #91760

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 7, 2023

Backport of #91758 to release/8.0

/cc @jkoritzinsky

Customer Impact

Infrastructure change required to build with a stable version.

Testing

Locally validated.

Risk

Low/Minimal

…'-'.

This fixes a build break found when we stabilize the package version (and the only separator in the informational version is '+' before the commit id)
@ghost
Copy link

ghost commented Sep 7, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91758 to release/8.0

/cc @jkoritzinsky

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Runtime.InteropServices

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review. once ready this can be merged

@jkoritzinsky jkoritzinsky added the Servicing-approved Approved for servicing release label Sep 7, 2023
@jkoritzinsky
Copy link
Member

Failures are all known.

@jkoritzinsky
Copy link
Member

@jeffschwMSFT can you merge this PR? I don't have permissions to merge into release/8.0

@jeffschwMSFT jeffschwMSFT merged commit 49b266d into release/8.0 Sep 8, 2023
110 of 119 checks passed
@jkotas jkotas deleted the backport/pr-91758-to-release/8.0 branch September 8, 2023 03:43
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants