Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly aggressive assert about array rank #91651

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Fix overly aggressive assert about array rank #91651

merged 1 commit into from
Sep 6, 2023

Conversation

AndyAyersMS
Copy link
Member

Closes #91349

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 5, 2023
@ghost ghost assigned AndyAyersMS Sep 5, 2023
@AndyAyersMS AndyAyersMS added area-VM-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 5, 2023
@AndyAyersMS AndyAyersMS mentioned this pull request Sep 6, 2023
Closed
@AndyAyersMS
Copy link
Member Author

Had one test fail, almost certainly unrelated. Opened #91653.

@AndyAyersMS AndyAyersMS merged commit 808c523 into dotnet:main Sep 6, 2023
106 of 108 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adityamandaleeka adityamandaleeka adityamandaleeka approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@AndyAyersMS AndyAyersMS

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert "rank < MAX_RANK" in runtime/src/coreclr/classlibnative/bcltype/arraynative.cpp Line: 812
3 participants
@AndyAyersMS @adityamandaleeka @jkotas