[Release/8.0] Fix x64 crossbuild on macOS arm64 #91635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cross build is failing due to the cpufeatures.c being compiled in. This file tries to extract cpu features using cpuid / getauxval that don't make sense to execute in the cross tools. This change disables compiling the cpufeatures.c for cross build and changes the JitGetProcessorFeatures to return zero in this case.
janvorli
added
Servicing-consider
jkotas
approved these changes
Sep 5, 2023
jeffschwMSFT
approved these changes
Sep 5, 2023
jkotas
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91413 to release/8.0
Customer Impact
When a customer attempts to do a cross build of .NET runtime for macOS x64 on macOS arm64, the build fails during cross tools build phase. It happens due to the cpufeatures.c/h using
TARGET_XXXifdefs instead ofHOST_XXXones.Testing
Local cross build of the runtime on macOS arm64, local build on macOS x64 and local build on linux arm64.
Risk
Low, the change does not cause different CPU features being detected.