Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the RequiresPreviewFeaturesAttribute from RefreshMemoryLimit #91622

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Delete the RequiresPreviewFeaturesAttribute from RefreshMemoryLimit #91622

merged 2 commits into from
Sep 5, 2023

Conversation

cshung
Copy link
Member

@cshung cshung commented Sep 5, 2023

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Sep 5, 2023
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned cshung Sep 5, 2023
@jkotas
Copy link
Member

jkotas commented Sep 5, 2023

Also, submit PR to delete the preview label in the docs (https://learn.microsoft.com/en-us/dotnet/api/system.gc.refreshmemorylimit?view=net-8.0). The API docs for CoreLib API are not updated automatically.

@normj normj mentioned this pull request Sep 5, 2023
Merged
@teo-tsirpanis teo-tsirpanis added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-System.Runtime, new-api-needs-documentation
Milestone: -

@mangod9
Copy link
Member

mangod9 commented Sep 5, 2023

looks like there are api compat failures as part of build too

@build-analysis build-analysis bot mentioned this pull request Sep 5, 2023
Open
@cshung cshung merged commit 4b9132f into dotnet:main Sep 5, 2023
171 checks passed
@cshung cshung deleted the public/delete-attribute branch September 5, 2023 23:57
@stephentoub
Copy link
Member

@cshung, I assume you intend to backport this to release/8.0?

@cshung
Copy link
Member Author

cshung commented Sep 6, 2023

@stephentoub Yes, that is the intention.

cshung added a commit to cshung/runtime that referenced this pull request Sep 13, 2023
@cshung
Delete the RequiresPreviewFeaturesAttribute from RefreshMemoryLimit (d…
bf805b3 
…otnet#91622)
@cshung cshung mentioned this pull request Sep 13, 2023
Merged
carlossanlop added a commit that referenced this pull request Sep 14, 2023
@cshung @carlossanlop
Delete the RequiresPreviewFeaturesAttribute from RefreshMemoryLimit (#…
e9464f7 
…91622) (#91688)

Co-authored-by: Carlos Sánchez López <1175054+carlossanlop@users.noreply.github.com>
@radical radical mentioned this pull request Sep 26, 2023
Closed
@radical radical mentioned this pull request Oct 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

@mangod9 mangod9 mangod9 approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@cshung cshung

Labels
area-System.Runtime new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cshung @jkotas @mangod9 @stephentoub @Maoni0 @teo-tsirpanis