-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Fix usage of load library #91490
Conversation
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #91483 to release/8.0 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. please get a code review. once ready this can be merged
@jeffschwMSFT or @jkotas or @carlossanlop CI is green and has been signed off. Please merge when convenient. |
Backport of #91483 to release/8.0
/cc @AaronRobinsonMSFT
Customer Impact
This usage violates API tenets for dotnet.
Testing
Validated with diagnostics tests.
Risk
Low. This use of
LoadLibraryW()
is only passed a full path anyways so the update toLoadLibraryExW()
passedLOAD_WITH_ALTERED_SEARCH_PATH
.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.