[release/8.0] [mono] Initialize module's image ALC for dynamic objects #90912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz,
lambdageek and
thaystg
as code owners
kotlarmilos
added
area-Codegen-AOT-mono
os-ios
|
Tagging subscribers to 'os-ios': @steveisok, @akoeplinger, @kotlarmilos Issue DetailsBackport of #90731 to release/8.0 /cc @kotlarmilos Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
kotlarmilos
added
Servicing-consider
This was referenced Aug 22, 2023
SamMonoRT
approved these changes
Aug 22, 2023
jeffschwMSFT
approved these changes
Aug 22, 2023
SamMonoRT
added
Servicing-approved
|
The failures are: I don't have permissions to merge this PR. |
|
@kotlarmilos I can merge it for you. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
##Description
Backport of #90731 to release/8.0
This PR initializes module's image ALC for dynamic objects created during the runtime. Dynamic assemblies have two images - one for the assembly, and one for the image. The assembly image had an ALC set, but the module image didn't have the ALC set. If a custom attribute depends on a type defined outside of the dynamic assembly, the dynamic assembly should have an ALC to resolve the type.
Customer Impact
The issue was discovered by a customer.
Testing
A runtime test has been added. Manual testing and automated testing on the CI were performed, ensuring that the tests are passing. The issue has been reproduced locally, and has been fixed.
Risk
Low risk. This change initializes an image property and adds a runtime test.
The change doesn't affect code that ships in a NuGet package.