Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] Update dependencies from dotnet/arcade #90665

Conversation

dotnet-maestro[bot]
Copy link
Contributor

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23408.1 to 1.0.0-beta.23415.1 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

  • Subscription: eec9d23c-5352-446c-273c-08db9cf9a54f
  • Build: 20230815.4
  • Date Produced: August 16, 2023 12:28:07 AM UTC
  • Commit: 46ff142f43e887d5f9a4d87ef39d72166f61db8d
  • Branch: refs/heads/main

…815.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23411.1 -> To Version 8.0.0-beta.23415.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23408.1 -> To Version 1.0.0-beta.23415.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Aug 16, 2023
@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Aug 16, 2023
@mmitche
Copy link
Member

mmitche commented Aug 16, 2023

@carlossanlop are the failures interesting here or can we merge this?

@carlossanlop
Copy link
Member

@lewing @steveisok these mono linker failures do not look familiar. Have we already backported a fix for them in the RC1 branch? if yes, then I can hit the "Update branch" button to confirm the CI looks good.

Failures:

Tests failed: D:\a\_work\1\s\artifacts\TestResults\Release\Mono.Linker.Tests_net8.0_x64.html [net8.0|x64]
  Custom attributes on `c' are not matching
  Expected: equivalent to <empty>
  But was:  < "System.Runtime.CompilerServices.NullableAttribute" >
  Extra (1): < "System.Runtime.CompilerServices.NullableAttribute" >
  Custom attributes on `T' are not matching
  Expected: equivalent to <empty>
  But was:  < "System.Runtime.CompilerServices.NullableAttribute" >
  Extra (1): < "System.Runtime.CompilerServices.NullableAttribute" >

@steveisok
Copy link
Member

@lewing @steveisok these mono linker failures do not look familiar. Have we already backported a fix for them in the RC1 branch? if yes, then I can hit the "Update branch" button to confirm the CI looks good.

@carlossanlop, did a quick spot check and I don't see a change that was backported. Do you have a link?

@carlossanlop
Copy link
Member

Found the issue: #90431

PR is merged too: #90449

I'll backport it.

@steveisok
Copy link
Member

@carlossanlop please merge when you have a moment.

@carlossanlop carlossanlop merged commit b5a0345 into release/8.0-rc1 Aug 16, 2023
185 of 190 checks passed
@carlossanlop carlossanlop deleted the darc-release/8.0-rc1-7b52f368-c040-4a14-9134-da2bca097931 branch August 16, 2023 23:36
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants