[release/8.0-rc1] Fix support for non-public default constructors using JsonIncludeAttribute #90615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
eiriktsarpalis
added
the
Servicing-consider
tarekgh
approved these changes
Aug 15, 2023
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #90612 to release/8.0-rc1 /cc @eiriktsarpalis Customer ImpactThe PR in #88452 added support for non-public constructors annotated with the TestingAdded unit tests covering the relevant scenario. RiskLow. Relatively straightforward changes made to the reflection resolver.
|
This was referenced Aug 15, 2023
carlossanlop
added
Servicing-approved
|
This was approved yesterday. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90612 to release/8.0-rc1
/cc @eiriktsarpalis
Customer Impact
The PR in #88452 added support for non-public constructors annotated with the
JsonConstructorattribute. The implementation missed out default constructor support in the reflection-based serializer as reported by this customer issue.Testing
Added unit tests covering the relevant scenario.
Risk
Low. Relatively straightforward changes made to the reflection resolver.