Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default implementation of static virtuals with method constraints #89061

Merged
merged 8 commits into from
Jul 19, 2023

Conversation

davidwrighton
Copy link
Member

  • The major problem was the logic which incorrectly would instantiate the methods when it wasn't necessary
  • As the number of flags to the implementation functions has grown very large, this change also includes logic converting them all to a single flags variable when passing them around

Fixes #73658
Fixes #78865

…constraints

Add support for default implmentation of static virtuals with method constraints
src/coreclr/inc/enum_class_flags.h Outdated Show resolved Hide resolved
src/coreclr/inc/enum_class_flags.h Outdated Show resolved Hide resolved
src/coreclr/inc/enum_class_flags.h Outdated Show resolved Hide resolved
src/coreclr/inc/enum_class_flags.h Outdated Show resolved Hide resolved
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
@davidwrighton davidwrighton merged commit d1adf81 into dotnet:main Jul 19, 2023
7 checks passed
@Joe4evr
Copy link
Contributor

Joe4evr commented Aug 10, 2023

Did this not get into preview 7 somehow? I ran my code that previously encountered #73658 and I'm still getting a VerificationException when calling GetInterfaceMap.

Additionally, in trying to make a minimized repo I'm encountering more bugs around getting a target method through reflection (at least one of which is also in .NET 7). Should I open a new issue for these? @AaronRobinsonMSFT @davidwrighton

@AaronRobinsonMSFT
Copy link
Member

@Joe4evr Can you try the nightly from https://github.com/dotnet/installer#table. I'm not sure if these fixes made it into preview 7.

@AaronRobinsonMSFT
Copy link
Member

If you are still hitting issues after trying the nightly, then please open a new issue.

@Joe4evr
Copy link
Contributor

Joe4evr commented Aug 10, 2023

@Joe4evr Can you try the nightly from https://github.com/dotnet/installer#table. I'm not sure if these fixes made it into preview 7.

Ah, thanks for that. Looks like I was concerned for nothing. That rc1 build does work in all the scenarios I tested.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants