Clean up debugger attributes tests.

[mrvoorhe]

• Remove SetupLinkerKeepDebugMembersAttribute. This isn't supported anymore by the linker.

• Remove NETCOREAPP behavior difference in debugger attribute removal tests

• Move DebuggerDisplayAttributeOnTypeWithNonExistentMethod to the KeepDebugMembers folder since that is the scenario this test is testing

[ghost]

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

---

• Remove SetupLinkerKeepDebugMembersAttribute. This isn't supported anymore by the linker.

• Remove NETCOREAPP behavior difference in debugger attribute removal tests

• Move DebuggerDisplayAttributeOnTypeWithNonExistentMethod to the KeepDebugMembers folder since that is the scenario this test is testing

Author:	mrvoorhe
Assignees:	-
Labels:	area-Debugger-mono, linkable-framework
Milestone:	-

[mrvoorhe]

@vitek-karas Do I have to do something to get the tests to rerun? The failure about

src/coreclr/tools/aot/Mono.Linker.Tests/TestCasesRunner/TestCaseMetadataProvider.cs(30,57): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'SetupLinkerKeepDebugMembersAttribute' does not exist in the current context

Seems out of date. I deleted that line.

[sbomer]

Note the error is for a file in src/coreclr/tools/aot, not src/tools/illink.

[mrvoorhe]

Note the error is for a file in src/coreclr/tools/aot, not src/tools/illink.

I did not see that coming! A copy of Mono.Linker.Tests\TestCasesRunner 🙈

[vitek-karas]

A copy of Mono.Linker.Tests\TestCasesRunner

Yeah - it's good and bad. It's good since we share the tests between illink and NativeAOT. It's bad because it's the same mess as in illink, just slightly different.

When I get some time I want to:

• Rename the assembly for NativeAOT - currently it's the same name between illink/NativeAOT and it can do bad things to CI/local builds sometimes
• See if we could refactor the runner to share code between the two in some easy way

[mrvoorhe]

Rename the assembly for NativeAOT - currently it's the same name between illink/NativeAOT and it can do bad things to CI/local builds sometimes

I think that's worth doing. If the file names had been different that might have been enough to get my brain to notice it was a different copy of TestCaseMetadataProvider.cs.

See if we could refactor the runner to share code between the two in some easy way

I didn't look it too closely but maybe you could share more following the pattern we do with UnityLinker's test suite. We inherit and override things.

C:\UnitySrc\dev>cd C:\UnitySrc\dev\il2cpp-12\Unity.Linker.Tests\TestCaseRunner\

C:\UnitySrc\dev\il2cpp-12\Unity.Linker.Tests\TestCaseRunner>dir
 Volume in drive C is Windows
 Volume Serial Number is CA0A-0107

 Directory of C:\UnitySrc\dev\il2cpp-12\Unity.Linker.Tests\TestCaseRunner

06/02/2023  01:25 PM    <DIR>          .
06/22/2023  01:01 PM    <DIR>          ..
02/09/2023  05:11 PM             4,833 CoreUtils.cs
02/09/2023  05:11 PM             3,479 ILDumper.cs
10/25/2021  03:27 PM    <DIR>          Invoking
09/23/2021  12:29 PM             8,618 OutputChecker.cs
02/09/2023  05:11 PM             2,596 StubAssertionUtils.cs
06/02/2023  01:25 PM             5,725 UnityAssemblyChecker.cs
05/19/2021  08:52 AM               413 UnityCompilerOptions.cs
10/14/2021  10:22 AM             1,327 UnityILCompiler.cs
02/09/2023  05:11 PM             3,456 UnityLinker.cs
02/09/2023  05:11 PM            16,104 UnityLinkerArgumentBuilder.cs
05/19/2021  08:52 AM               947 UnityLinkerArgumentBuilderEditorMode.cs
03/03/2022  01:54 PM             5,013 UnityObjectFactory.cs
03/03/2022  01:54 PM             1,044 UnityObjectFactoryEditorMode.cs
02/09/2023  05:11 PM             4,710 UnityPeVerifier.cs
04/21/2023  09:19 AM            42,403 UnityResultChecker.cs
05/19/2021  08:52 AM               420 UnitySetupCompileInfo.cs
02/09/2023  05:11 PM             3,268 UnityTestCaseAssemblyResolver.cs
02/09/2023  05:11 PM             8,014 UnityTestCaseCompilationMetadataProvider.cs
02/09/2023  05:11 PM            14,233 UnityTestCaseCompiler.cs
02/09/2023  05:11 PM            12,209 UnityTestCaseMetadataProvider.cs
04/24/2023  11:53 AM             5,605 UnityTestCaseSandbox.cs
06/02/2023  01:25 PM             5,199 UnityTestRunner.cs
02/09/2023  05:11 PM             3,144 UnityTestRunnerEditorMode.cs

We have a lot of the same files. They just inherit and extend rather than copy whole sale from upstream.

Then again, maybe you're use case is different enough that trying to follow the same pattern would lead to more api breaks for us, in which case feel free to stick with copying whole sale 😄

[mrvoorhe]

@vitek-karas I think these changes are good now?

[vitek-karas]

In the product we went with source sharing and partial types typically. But it was mostly for performance reasons to avoid casting a virtual calls everywhere. I would need to look into this some more which approach would work best for the tests.