[release/7.0] Fix HTTP/3 and HTTTP/2 header decoder buffer allocation #85977
Conversation
* Add test for literal field without name reference * Fix header name buffer allocation * Add more tests * Unified QPackDecoderTest test files * Fix variable name * Fixed HPackDecoder and ported QPack tests * Feedback --------- Co-authored-by: ManickaP <mapichov@microsoft.com>
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #78516 Backports #78862 Customer impactReliability problem in HTTP/2 and HTTP/3, where some requests/responses with large headers that should be accepted might end up throwing exception.
This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET. TestingAdded tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI. RiskLow, as this affects only QPack (H/3 is still not as wide-spread as other HTTP versions) and HPack in (rare) case of 4KB+ sized headers data buffers.
|
|
From: #85337 (comment) Approved by Tactics (@SteveMCarroll) on 4/27 via email. Marking as servicing-approved. |
Fixes #78516
Backports #78862
Customer impact
Reliability problem in HTTP/2 and HTTP/3, where some requests/responses with large headers that should be accepted might end up throwing exception.
This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET.
Testing
Added tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI.
Risk
Low, as this affects only QPack (H/3 is still not as wide-spread as other HTTP versions) and HPack in (rare) case of 4KB+ sized headers data buffers.