Implement ICorProfilerInfo14::GetNonGCHeapBounds #85434
Conversation
|
Tagging subscribers to this area: @tommcdon Issue DetailsContributes to dotnet/diagnostics#4156
|
| Object* result = reinterpret_cast<Object*>(nextObj); | ||
| INDEBUG(result->Validate()); | ||
| return result; | ||
| return reinterpret_cast<Object*>(nextObj); |
There was a problem hiding this comment.
we agreed not to use COOP (Validate() needs it)
| // Add test coverage for IsFrozenObject API, currently, it is expected to return true | ||
| // for objects from non-GC heap (it might also return true for frozen segments we don't track) | ||
| BOOL isFrozen; | ||
| hr = pCorProfilerInfo->IsFrozenObject(obj, &isFrozen); |
There was a problem hiding this comment.
@cshung added test coverage for IsFrozenObject on your request
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures are #85081 and ci timeouts |
|
Failures are known, #85637 |
|
|
||
| if (pcObjectRanges != nullptr) | ||
| { | ||
| *pcObjectRanges = segmentsToInspect; |
There was a problem hiding this comment.
@EgorBo - I think we want *pcObjectRanges = segmentsCount
I'd expect the current behavior will make a test case like this fail:
ULONG count
GetNonGCHeapBounds(0, &count, nullptr);
ranges = new ranges[count];
GetNonGCHeapBounds(count, nullptr, ranges);
There was a problem hiding this comment.
@EgorBo - I think we want
*pcObjectRanges = segmentsCountI'd expect the current behavior will make a test case like this fail:
ULONG count GetNonGCHeapBounds(0, &count, nullptr); ranges = new ranges[count]; GetNonGCHeapBounds(count, nullptr, ranges);
Ah, makes sense, I thought it was "how many entries were written to ranges". Will fix
There was a problem hiding this comment.
Yeah, I've seen it used that way too in other interfaces, but I checked GetGenerationBounds() for the GC case and it appears to have the segmentsCount semantics there so presumably we want to match the behavior.
ghost
locked as resolved and limited conversation to collaborators
Contributes to dotnet/diagnostics#4156