Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview4] [browser] Fix webcil lazy loading and satellite assemblies in Wasm SDK #85400

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Apr 26, 2023

Backport of #85335 to release/8.0-preview4

Customer Impact

In previous PRs we enabled .webcil format for blazor, which is a possible solution for AV mitigation.
This PR fixes support for lazy assembly loading and satellite assemblies in .webcil format.

Testing

Manual

Risk

Low. Changes touch mostly parts related to newly introduced webcil

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels Apr 26, 2023
@maraf maraf added this to the 8.0.0 milestone Apr 26, 2023
@maraf maraf self-assigned this Apr 26, 2023
@maraf maraf requested a review from radical as a code owner April 26, 2023 15:02
@maraf maraf requested review from lewing and lambdageek April 26, 2023 15:02
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #85335 to release/8.0-preview4

Customer Impact

In previous PRs we enabled .webcil format for blazor, which is a possible solution for AV mitigation.
This PR fixes support for lazy assembly loading and satellite assemblies in .webcil format.

Testing

Manual

Risk

Low. Changes touch mostly parts related to newly introduced webcil

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono

Milestone: 8.0.0

@maraf maraf added the Servicing-consider Issue for next servicing release review label Apr 26, 2023
@lewing
Copy link
Member

lewing commented Apr 26, 2023

dotnet/aspnetcore#47905 is the follow-up in aspnetcore

@maraf
Copy link
Member Author

maraf commented Apr 27, 2023

Failures are unrelated

@lewing lewing merged commit bc84bd3 into dotnet:release/8.0-preview4 Apr 27, 2023
@maraf maraf deleted the WasmWebcilFix80p4 branch April 27, 2023 15:52
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants