Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hot_reload] assorted hot reload fixes for cumulative property updates #85351

Merged
merged 4 commits into from
Apr 25, 2023
Merged

[hot_reload] assorted hot reload fixes for cumulative property updates #85351

merged 4 commits into from
Apr 25, 2023

Commits on Apr 25, 2023

  1. [hot_reload] remove unneeded assertion 

    `is_addition` is already defined as `token_index-1 >=
delta_info->count[token_table].prev_gen_rows` so:

1. the assertion as written is wrong for cumulative updates that add
new properties or events
2. the assertion would be trivially true if it was updated to use
`delta_info->count[token_table].prev_gen_rows`.

Fixes the ability to cumulatively add new properties
    @lambdageek
    lambdageek committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    05b446a View commit details
    Browse the repository at this point in the history

  2. Update generation on MonoClassMetadataUpdateInfo when adding members 

    Give recompute_ginst_update_info something to work with.
    @lambdageek
    lambdageek committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    3c0cd21 View commit details
    Browse the repository at this point in the history

  3. assert that generic instances don't call hot_reload_get_property 

    token-based lookup should only happen for class defs or GTDs
    @lambdageek
    lambdageek committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    c009f37 View commit details
    Browse the repository at this point in the history

  4. update regression test

    @lambdageek
    lambdageek committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    8d4953a View commit details
    Browse the repository at this point in the history