Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Fix HTTTP/2 header decoder buffer allocation #85341

Closed
wants to merge 1 commit into from

Conversation

ManickaP
Copy link
Member

@ManickaP ManickaP commented Apr 25, 2023

Fixes #78516

Backports #78862

Customer impact

Reliability problem in HTTP/2 (HPack), where some requests/responses with large headers (4KB+) that should be accepted might end up throwing exception.

This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET.

Testing

Added tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI.

Risk

Low, as this affects only (rare) case of 4KB+ headers data buffers in HTTP/2 (HPack).

* Add test for literal field without name reference

* Fix header name buffer allocation

* Add more tests

* Unified QPackDecoderTest test files

* Fix variable name

* Fixed HPackDecoder and ported QPack tests

* Feedback

---------

Co-authored-by: ManickaP <mapichov@microsoft.com>
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #78516

Backports #78862

Customer impact

Reliability problem in HTTP/2, where some requests/responses with large headers that should be accepted might end up throwing exception.

  • In HPack case (HTTP/2 scenarios), the issue is much less likely to be hit as it requires 4KB of headers.

This is a shared code with Kestrel so this affects server side as well - expect follow up PR in ASP.NET.

Testing

Added tests for the root cause and similar scenarios, increasing test coverage. All of those are ran in CI.

Risk

Low, as this affects only HPack in (rare) case of 4KB+ sized headers data buffers.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ManickaP
Copy link
Member Author

Failures look like #76454, timeouts with machine provisioning and/or test execution.

@karelz
Copy link
Member

karelz commented Apr 28, 2023

Approved by Tactics (@SteveMCarroll) on 4/27 via email. Marking as servicing-approved.

@karelz karelz added the Servicing-approved Approved for servicing release label Apr 28, 2023
@karelz karelz added this to the 6.0.x milestone Apr 28, 2023
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same request as in the 7.0 PR - Rebase to release/6.0-staging, and make sure to merge before May 15th (code complete) if you intend to include this fix in the June Release.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label May 4, 2023
@ManickaP
Copy link
Member Author

ManickaP commented May 9, 2023

Closed in favor of #85976

@ManickaP ManickaP closed this May 9, 2023
@ManickaP ManickaP deleted the release/6.0 branch May 9, 2023 14:27
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http needs-author-action An issue or pull request that requires more info or actions from the author. Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants