Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Iran time zone test case #83952

Merged
merged 4 commits into from
Mar 27, 2023
Merged

Fix Iran time zone test case #83952

merged 4 commits into from
Mar 27, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Mar 26, 2023

Fixes #83901

In the recent ICU updates, there has been some changing in the Iran time zone display name which broke our test. The fix here is allow both the old and new names to ensure the test succeed in all platforms.

@ghost ghost assigned tarekgh Mar 26, 2023
@tarekgh tarekgh added this to the 8.0.0 milestone Mar 26, 2023
@tarekgh tarekgh requested a review from jkotas March 26, 2023 23:19
Co-authored-by: Stephen Toub <stoub@microsoft.com>
@jkotas
Copy link
Member

jkotas commented Mar 27, 2023

Test failures related to the change: System.InvalidOperationException : The test method expected 5 parameter values, but 4 parameter values were provided.

@tarekgh tarekgh merged commit b1fbb80 into dotnet:main Mar 27, 2023
@tarekgh tarekgh deleted the FixIranTimeZoneTest branch March 27, 2023 18:04
@tarekgh
Copy link
Member Author

tarekgh commented Mar 28, 2023

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4547945741

@github-actions
Copy link
Contributor

@tarekgh backporting to release/7.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix Iran time zone test case
Using index info to reconstruct a base tree...
M	src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
CONFLICT (content): Merge conflict in src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Iran time zone test case
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@tarekgh an error occurred while backporting to release/7.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@tarekgh
Copy link
Member Author

tarekgh commented Mar 28, 2023

/backport to release/6.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/4547981968

@github-actions
Copy link
Contributor

@tarekgh backporting to release/6.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix Iran time zone test case
Using index info to reconstruct a base tree...
M	src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
CONFLICT (content): Merge conflict in src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Iran time zone test case
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@tarekgh an error occurred while backporting to release/6.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@carlossanlop
Copy link
Member

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/4548209582

@github-actions
Copy link
Contributor

@carlossanlop backporting to release/7.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Fix Iran time zone test case
Using index info to reconstruct a base tree...
M	src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
CONFLICT (content): Merge conflict in src/libraries/System.Runtime/tests/System/TimeZoneInfoTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix Iran time zone test case
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@carlossanlop an error occurred while backporting to release/7.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Platform_TimeZoneNames failing for Iran time zones on macOS
4 participants