Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Produce crashreport.json and use llvm-symbolizer to create st… #81379

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

kunalspathak
Copy link
Member

…ack trace (#77578)"

This reverts commit ff987dc.

I will work on a solution that includes symbols only for PRs.

Fixes: #81374

@ghost
Copy link

ghost commented Jan 30, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

…ack trace (#77578)"

This reverts commit ff987dc.

I will work on a solution that includes symbols only for PRs.

Fixes: #81374

Author: kunalspathak
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@kunalspathak
Copy link
Member Author

@agocke

Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tommcdon
Copy link
Member

cc @hoyosjs

@kunalspathak kunalspathak merged commit 3c76e14 into dotnet:main Jan 30, 2023
@kunalspathak kunalspathak deleted the revert_crashreport branch January 30, 2023 21:42
kunalspathak added a commit to kunalspathak/runtime that referenced this pull request Jan 30, 2023
kunalspathak added a commit that referenced this pull request Jan 31, 2023
* Revert "Revert "Produce crashreport.json and use llvm-symbolizer to create stack trace (#77578)" (#81379)"

This reverts commit 3c76e14.

* Add nativeSymbols only for PRs
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish size regression on Linux
4 participants