Convert JitHashTable iteration to range-based for
#80265
Conversation
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue Detailsnull
|
|
No diffs (as expected) but TP improvements around 0.22% |
|
@dotnet/jit-contrib PTAL |
| @@ -11312,10 +11309,9 @@ void Compiler::JitTestCheckVN() | |||
| { | |||
| printf("\nJit Testing: Value numbering.\n"); | |||
| } | |||
| for (NodeToTestDataMap::KeyIterator ki = testData->Begin(); !ki.Equal(testData->End()); ++ki) | |||
| for (GenTree* const node : NodeToTestDataMap::KeyIteration(testData)) | |||
There was a problem hiding this comment.
iirc, we could simplify a lot of this by declaring something like the following in NodeToTestDataMap
public:
using const_iterator = NodeToTestDataMap::KeyIteration;That should allow simply for (GenTree* const node : testData) which is a lot simpler and doesn't require line wrapping/etc
Provided we don't need multiple iterators dealing with the same type, everything should work out nicely.
We should likewise be able to annotate whether they are "random access" or "contiguous" if that is important.
There was a problem hiding this comment.
Actually, looks like it just needs begin and end
The using iterator and using const_iterator can also help with some templating and other scenarios, but aren't strictly required to use for (T item : data)
No description provided.