Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Update failure message for helix retry #78655

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

radical
Copy link
Member

@radical radical commented Nov 21, 2022

The message in the test report is:

<Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message>

Update to use regex, and match the whole message.

Fixes #76528 .

The message in the test report is:
```xml
<Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message>
```

Update to use regex, and match the whole message.
@ghost
Copy link

ghost commented Nov 21, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

The message in the test report is:

<Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message>

Update to use regex, and match the whole message.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono, test-failure

Milestone: -

@ghost ghost assigned radical Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The message in the test report is:

<Message>System.IO.IOException : [testId: 34] Timed out after 20s waiting for the browser to be ready: C:\helix\work\correlation\chrome-win\chrome.exe</Message>

Update to use regex, and match the whole message.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono, test-failure

Milestone: -

@radical radical marked this pull request as ready for review November 21, 2022 22:39
@radical
Copy link
Member Author

radical commented Nov 21, 2022

Merging this because the change was tested explicitly. And the normal CI run won't catch trigger anything.

@radical radical merged commit e71db8d into dotnet:main Nov 21, 2022
@radical radical deleted the chrome-retry branch November 21, 2022 22:59
@ghost ghost locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] add support for retrying debugger tests when chrome launch times out
2 participants