Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error due to unused windowSize parameter in pal_console.c #78056

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Nov 8, 2022

src/native/libs/System.Native/pal_console.c(42,45): error G60964CEC: (NETCORE_ENGINEERING_TELEMETRY=Build) unused parameter 'windowSize' [-Werror,-Wunused-parameter]

Introduced in #75824

```
src/native/libs/System.Native/pal_console.c(42,45): error G60964CEC: (NETCORE_ENGINEERING_TELEMETRY=Build) unused parameter 'windowSize' [-Werror,-Wunused-parameter]
```
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, big thanks for the fix and apologies for breaking you @akoeplinger !

Just for my education: I did not see any failing Android builds in #75824, so I assume we don't run them by default?

@adamsitnik adamsitnik added this to the 8.0.0 milestone Nov 8, 2022
@tarekgh tarekgh merged commit 253cede into main Nov 9, 2022
@tarekgh tarekgh deleted the akoeplinger-patch-2 branch November 9, 2022 02:45
@akoeplinger
Copy link
Member Author

Just for my education: I did not see any failing Android builds in #75824, so I assume we don't run them by default?

Correct, we use some heuristics to detect whether to trigger them (e.g. changes in src/mono) so this didn't get triggered there. No big deal, we knew we'd sometimes have build errors sneak in when we made that tradeoff.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants