Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to issue with more info on flaky behavior #77859

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Links to issue with more info on flaky behavior #77859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/libraries/Microsoft.Extensions.Configuration/tests/FunctionalTests/ConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ public void OnLoadErrorCanIgnoreErrors()
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public void CanSetValuesAndReloadValues()
{
WriteTestFiles();
Expand Down Expand Up @@ -508,7 +508,7 @@ public void CanSetValuesAndReloadValues()
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task ReloadOnChangeWorksAfterError()
{
_fileSystem.WriteFile("reload.json", @"{""JsonKey1"": ""JsonValue1""}");
Expand Down Expand Up @@ -539,7 +539,7 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task TouchingFileWillReload()
{
_fileSystem.WriteFile("reload.json", @"{""JsonKey1"": ""JsonValue1""}");
Expand Down Expand Up @@ -576,7 +576,7 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task CreatingOptionalFileInNonExistentDirectoryWillReload()
{
var directory = Path.GetRandomFileName();
Expand Down Expand Up @@ -610,7 +610,7 @@ await WaitForChange(
}

[Theory]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
[InlineData(false)]
[InlineData(true)]
public async Task DeletingFilesThatRedefineKeysWithReload(bool optional)
Expand Down Expand Up @@ -691,7 +691,7 @@ await WaitForChange(
}

[Theory]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
[InlineData(false)]
[InlineData(true)]
public async Task DeletingFileWillReload(bool optional)
Expand Down Expand Up @@ -730,7 +730,7 @@ await WaitForChange(
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task CreatingWritingDeletingCreatingFileWillReload()
{
var config = CreateBuilder()
Expand Down Expand Up @@ -910,7 +910,7 @@ public void CanEnumerateProviders()
}

[Fact]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/33992")]
[ActiveIssue("File watching is flaky (particularly on non windows. https://github.com/dotnet/runtime/issues/42036")]
public async Task TouchingFileWillReloadForUserSecrets()
{
string userSecretsId = "Test";
Expand Down