Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF][MAUI] Update the Nuget Config used for Maui net6 apps. #77739

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

LoopedBard3
Copy link
Member

Update the Nuget Config used for Maui net6 apps so the latest 6.0.11 runtimes are findable from the custom feeds.

@ghost
Copy link

ghost commented Nov 1, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Update the Nuget Config used for Maui net6 apps so the latest 6.0.11 runtimes are findable from the custom feeds.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure-coreclr

Milestone: -

@LoopedBard3
Copy link
Member Author

Most tests have succeeded and this only changes perf infra.

@LoopedBard3 LoopedBard3 merged commit 40df8f6 into dotnet:main Nov 1, 2022
@LoopedBard3 LoopedBard3 deleted the PerfMauiFixNet6Runs branch November 1, 2022 20:00
@@ -27,7 +27,7 @@ steps:

# Get the current maui nuget config so all things can be found and darc based package sources are kept up to date.
- script: |
curl -o NuGet.config 'https://github.com/raw/dotnet/maui/main/NuGet.config'
curl -o NuGet.config 'https://github.com/raw/dotnet/maui/net6.0/NuGet.config'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you actually want the net7.0 branch here? It has 6.0.11 feeds:

https://github.com/dotnet/maui/blob/net7.0/NuGet.config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested this, the net6.0 NuGet config also allowed the apps to build, if this turns out to not be the case I will make another PR to use net7.0.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants