Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Control if invalid configuration values are swallowed or thrown #77708

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Control if invalid configuration values are swallowed or thrown #77708

merged 3 commits into from
Nov 6, 2022

Conversation

SteveDunn
Copy link
Contributor

Implements #73915

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements #73915

Author: SteveDunn
Assignees: -
Labels:

area-Extensions-Configuration, community-contribution
Milestone: -

@tarekgh tarekgh added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels Nov 1, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@tarekgh
Copy link
Member

tarekgh commented Nov 1, 2022

@SteveDunn could you please resolve the conflict and address the minor comment on the change?

Also are you interested to fill the breaking change template as described in the comment #77708 (comment)? it is ok if not, I can do it later when we merge.

@SteveDunn
Copy link
Contributor Author

Unfortunately I'm not free until the weekend, but if that's ok then I'd be happy to.

@tarekgh
Copy link
Member

tarekgh commented Nov 2, 2022

Unfortunately I'm not free until the weekend, but if that's ok then I'd be happy to.

Can at least resolve the merge conflict?

@SteveDunn SteveDunn force-pushed the do-not-swallow-conversion-exceptions branch from b101fe4 to d033596 Compare November 3, 2022 21:11
@SteveDunn SteveDunn mentioned this pull request Nov 3, 2022
Closed
2 tasks
@SteveDunn
Copy link
Contributor Author

SteveDunn commented Nov 3, 2022 •
edited
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@SteveDunn
Copy link
Contributor Author

SteveDunn commented Nov 3, 2022 •
edited
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.
When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

I spotted an issue with the grammar - highlighted below:

image

^^ cc @dotnet/compat

@SteveDunn
Copy link
Contributor Author

Unfortunately I'm not free until the weekend, but if that's ok then I'd be happy to.

Can at least resolve the merge conflict?

Rebased to fix the conflict and added the breaking change docs.

@tarekgh
Copy link
Member

tarekgh commented Nov 3, 2022

@dotnet/compat could you please help in fixing the grammar issue mentioned in the comment #77708 (comment)?

@tarekgh tarekgh removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Nov 3, 2022
This was referenced Nov 4, 2022
Closed
Closed
@tarekgh tarekgh merged commit 264d739 into dotnet:main Nov 6, 2022
@SteveDunn SteveDunn deleted the do-not-swallow-conversion-exceptions branch November 7, 2022 03:40
@tarekgh tarekgh mentioned this pull request Nov 8, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees
No one assigned
Labels
area-Extensions-Configuration breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveDunn @tarekgh