Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JIT] X64 - More replacement sequences for integer multiplication by a constant #77137

Merged
merged 57 commits into from
Nov 5, 2022
Merged

[JIT] X64 - More replacement sequences for integer multiplication by a constant #77137

merged 57 commits into from
Nov 5, 2022

Commits on Oct 13, 2022

  1. Using 3 instruction sequence for x64 multiply

    @TIHan
    TIHan committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    78c3247 View commit details
    Browse the repository at this point in the history

  2. Do not do this in morph. Do it in codegen now.

    @TIHan
    TIHan committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    06a60e1 View commit details
    Browse the repository at this point in the history

  3. Fixing codegen

    @TIHan
    TIHan committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    7fb0095 View commit details
    Browse the repository at this point in the history

  4. Only allow values under 127 and do not skip mov - correctness testing

    @TIHan
    TIHan committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    86edb6c View commit details
    Browse the repository at this point in the history

  5. Try to fix tests

    @TIHan
    TIHan committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    0955d11 View commit details
    Browse the repository at this point in the history

  6. cleanup

    @TIHan
    TIHan committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    865cf95 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Moving to Lowering

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    999eac0 View commit details
    Browse the repository at this point in the history

  2. Quick fix

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6ebf58e View commit details
    Browse the repository at this point in the history

  3. Fully works in lowering now

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6e8f28c View commit details
    Browse the repository at this point in the history

  4. Account for all ints

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    94968a4 View commit details
    Browse the repository at this point in the history

  5. Take into account codegen opts

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    64b523a View commit details
    Browse the repository at this point in the history

  6. Minor cleanup

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    1cde9c0 View commit details
    Browse the repository at this point in the history

  7. Minor cleanup

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    c6fba6e View commit details
    Browse the repository at this point in the history

  8. Fixed test

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ff2b9a1 View commit details
    Browse the repository at this point in the history

  9. Added int multiply disasm checks. Fixed SuperFileCheck namespace bug.… 

    … Made SuperFileCheck anchors more likely to match.
    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    338dbe5 View commit details
    Browse the repository at this point in the history

  10. Update comments

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    106c6b7 View commit details
    Browse the repository at this point in the history

  11. Update comments

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    8fc5b37 View commit details
    Browse the repository at this point in the history

  12. Update comments

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e5835db View commit details
    Browse the repository at this point in the history

  13. Update comments

    @TIHan
    TIHan committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3be48bf View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. Formatting

    @TIHan
    TIHan committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    b3d4a5f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Fixing build

    @TIHan
    TIHan committed Oct 16, 2022
    Configuration menu
    Copy the full SHA
    843617a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Fixing build again

    @TIHan
    TIHan committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    74b1071 View commit details
    Browse the repository at this point in the history

  2. minor rename

    @TIHan
    TIHan committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    90b7e7d View commit details
    Browse the repository at this point in the history

  3. Moving x64 multiply codegen optimizations to lowering

    @TIHan
    TIHan committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    ead83a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Using ReplaceWithLclVar

    @TIHan
    TIHan committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b5193c0 View commit details
    Browse the repository at this point in the history

  2. Feedback. Removed use of FULL-LINE as it is more readable not strictl… 

    …y necessary. Forgot to add an additional instruction to a disasm test.
    @TIHan
    TIHan committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    214625f View commit details
    Browse the repository at this point in the history

  3. Merged

    @TIHan
    TIHan committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    f7181d2 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into mul-opt-x64-part2

    @TIHan
    TIHan committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    99c11b4 View commit details
    Browse the repository at this point in the history

  5. Minor fix

    @TIHan
    TIHan committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    9ff6393 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Formatting

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    75313fb View commit details
    Browse the repository at this point in the history

  2. merging

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c101d1b View commit details
    Browse the repository at this point in the history

  3. Merging

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    647cddb View commit details
    Browse the repository at this point in the history

  4. Adding codegen opts back, but disabling lowering opts if min-opts is … 

    …enabled
    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    79bc2d5 View commit details
    Browse the repository at this point in the history

  5. Little more changes

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    47c818d View commit details
    Browse the repository at this point in the history

  6. Formatting

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    55b6212 View commit details
    Browse the repository at this point in the history

  7. Remove codegen opts

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    1a736ff View commit details
    Browse the repository at this point in the history

  8. Update comments

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    c042862 View commit details
    Browse the repository at this point in the history

  9. Added test case for address-exposed

    @TIHan
    TIHan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    bba5ba0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Added TryLowerLshWithConstant

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    164f233 View commit details
    Browse the repository at this point in the history

  2. Cleanup

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    88311d6 View commit details
    Browse the repository at this point in the history

  3. Removed TryLowerLshWithConstant

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    160c68e View commit details
    Browse the repository at this point in the history

  4. Handle GT_LSH to emit lea if const is 3

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    4c9f7d3 View commit details
    Browse the repository at this point in the history

  5. Added tests.

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    a80dd11 View commit details
    Browse the repository at this point in the history

  6. Updated comments

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    d8b4228 View commit details
    Browse the repository at this point in the history

  7. Revert LowerShift

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    e7b140d View commit details
    Browse the repository at this point in the history

  8. Remove IndexWithScale

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    384ff0b View commit details
    Browse the repository at this point in the history

  9. Fix build

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    a935699 View commit details
    Browse the repository at this point in the history

  10. Update comment

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    21335a6 View commit details
    Browse the repository at this point in the history

  11. Formatting

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    05ac3f7 View commit details
    Browse the repository at this point in the history

  12. Update comments. Fix disasm test.

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    85ca0f4 View commit details
    Browse the repository at this point in the history

  13. Another minor test change

    @TIHan
    TIHan committed Oct 21, 2022
    Configuration menu
    Copy the full SHA
    e633fef View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Fix test

    @TIHan
    TIHan committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    5a459d8 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @TIHan
    TIHan committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    f40aa1c View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Feedback

    @TIHan
    TIHan committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    19d26d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Update IntMultiply.cs

    @TIHan
    TIHan committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    923d10b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Update codegenxarch.cpp

    @TIHan
    TIHan committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    5ac902d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2022

  1. Update codegenxarch.cpp

    @TIHan
    TIHan committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    c8fb73b View commit details
    Browse the repository at this point in the history