Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out addresses that are not in bookkeeping range during background promote #77067

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Oct 14, 2022

No description provided.

@cshung cshung self-assigned this Oct 14, 2022
@ghost
Copy link

ghost commented Oct 14, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

@jkotas
Copy link
Member

jkotas commented Oct 15, 2022

Is this fixing any known bug or crash?

@cshung
Copy link
Member Author

cshung commented Oct 15, 2022

Is this fixing any known bug or crash?

It fixed a crash if we set COMPlus_gcConservative to 1 and run the reliability framework test.

I was attempting to use CoreCLR to figure out what might have gone wrong with the NativeAOT CI failure.

We have found something, but not the one that is causing the CI failure.

src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
src/coreclr/gc/gc.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the slight refactoring we talked about, the rest LGTM

@cshung cshung force-pushed the public/background-promote-filter branch from 85e358d to d72e781 Compare October 21, 2022 08:14
@cshung cshung merged commit 2acef87 into dotnet:main Oct 21, 2022
@cshung cshung deleted the public/background-promote-filter branch October 21, 2022 16:28
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants