Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#76596 update icu version for norwegian culture #77003

Merged
merged 5 commits into from
Oct 17, 2022
Merged

#76596 update icu version for norwegian culture #77003

merged 5 commits into from
Oct 17, 2022

Conversation

mkhamoyan
Copy link
Member

Updating icu version after adding "nb-NO" culture in icu filters dotnet/icu#271
Fix #76596

@ghost ghost assigned mkhamoyan Oct 13, 2022
@ghost
Copy link

ghost commented Oct 13, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating icu version after adding "nb-NO" culture in icu filters dotnet/icu#271
Fix #76596

Author: mkhamoyan
Assignees: -
Labels:

area-System.Globalization
Milestone: -

@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

@mkhamoyan is there a test in runtime which validates the culture is there?

@mkhamoyan
Copy link
Member Author

@mkhamoyan is there a test in runtime which validates the culture is there?

No, I modified and checked locally only. Will add test case checking that.

@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

tarekgh
tarekgh reviewed Oct 13, 2022
View reviewed changes
src/libraries/System.Globalization/tests/CultureInfo/CultureInfoAll.cs Outdated
[InlineData("nb-NO")]
public void ContainsCulture(string culture)
{
var cultures = CultureInfo.GetCultures(CultureTypes.AllCultures).ToList();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need ToList() here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@tarekgh tarekgh added the os-ios Apple iOS label Oct 13, 2022
@ghost
Copy link

ghost commented Oct 13, 2022

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

Updating icu version after adding "nb-NO" culture in icu filters dotnet/icu#271
Fix #76596

Author: mkhamoyan
Assignees: mkhamoyan
Labels:

area-System.Globalization, os-ios
Milestone: -

@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Oct 13, 2022
Closed
Closed
@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Oct 15, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mkhamoyan
Copy link
Member Author

Failures are unrelated to the changes.

@mkhamoyan mkhamoyan merged commit 4574ccb into main Oct 17, 2022
@akoeplinger akoeplinger deleted the 76596_update_icu_version branch October 27, 2022 13:13
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@steveisok steveisok Awaiting requested review from steveisok

Assignees

@mkhamoyan mkhamoyan

Labels
area-System.Globalization os-ios Apple iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A DateTime.ToString with CultureInfo("nb-NO") gives the wrong datetime string output on iOS
4 participants
@mkhamoyan @steveisok @lewing @tarekgh