Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double the size of new frozen segments #76870

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Double the size of new frozen segments #76870

merged 2 commits into from
Oct 11, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Oct 11, 2022 •
edited
Loading

Reduce number of frozen segments in large apps, see #76151 (comment) by doubling size of new segments.

Segment0: 4Mb
Segment1: 8Mb
Segment2: 16Mb
Segment3: 4Mb (e.g. it tried to reserve 32Mb but there were not enough memory for that)
Segment4: 8Mb
...

@ghost ghost assigned EgorBo Oct 11, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 11, 2022
Closed
2 tasks
@build-analysis build-analysis bot mentioned this pull request Oct 11, 2022
Closed
2 tasks
jkotas
jkotas approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build-analysis build-analysis bot mentioned this pull request Oct 11, 2022
Closed
@EgorBo EgorBo merged commit 8c43676 into dotnet:main Oct 11, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 11, 2022
Closed
2 tasks
@EgorBo EgorBo mentioned this pull request Nov 6, 2022
Closed
14 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees

@EgorBo EgorBo

Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @jkotas