Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Debt - Microsoft.Extensions.Hosting #76692

Merged
merged 8 commits into from
Oct 14, 2022
Merged

API Debt - Microsoft.Extensions.Hosting #76692

merged 8 commits into from
Oct 14, 2022

Conversation

Nick-Stanton
Copy link
Member

@Nick-Stanton Nick-Stanton commented Oct 5, 2022 •
edited
Loading

Summary

Fixes #43915 pending additional PR to resolve namespace summary for the following:

  • Microsoft.Extensions.Hosting
  • Microsoft.Extensions.Hosting.Systemd
  • Microsoft.Extensions.Hosting.WindowsServices

as well as writing in descriptions for the following parameterless constructors:

  • M:Microsoft.Extensions.Hosting.BackgroundService.#ctor
  • M:Microsoft.Extensions.Hosting.ConsoleLifetimeOptions.#ctor
  • M:Microsoft.Extensions.Hosting.HostOptions.#ctor

Obsoletes

The following are obsolete (to my knowledge):

  • F:Microsoft.Extensions.Hosting.EnvironmentName.Development
  • F:Microsoft.Extensions.Hosting.EnvironmentName.Production
  • F:Microsoft.Extensions.Hosting.EnvironmentName.Staging

@Nick-Stanton Nick-Stanton requested review from carlossanlop and a team October 5, 2022 23:33
@Nick-Stanton Nick-Stanton self-assigned this Oct 5, 2022
@ghost
Copy link

ghost commented Oct 5, 2022

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Fixes #43915 pending additional PR to resolve namespace summary for the following:

  • Microsoft.Extensions.Hosting
  • Microsoft.Extensions.Hosting.Systemd
  • Microsoft.Extensions.Hosting.WindowsServices

The following are obsolete (to my knowledge):

  • F:Microsoft.Extensions.Hosting.EnvironmentName.Development
  • F:Microsoft.Extensions.Hosting.EnvironmentName.Production
  • F:Microsoft.Extensions.Hosting.EnvironmentName.Staging
Author: Nick-Stanton
Assignees: Nick-Stanton
Labels:

area-Extensions-Hosting
Milestone: -

tarekgh
tarekgh approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments. LGTM otherwise. Thanks @Nick-Stanton!

@build-analysis build-analysis bot mentioned this pull request Oct 6, 2022
Closed
@Nick-Stanton Nick-Stanton mentioned this pull request Oct 6, 2022
Merged
@Nick-Stanton Nick-Stanton mentioned this pull request Oct 6, 2022
Closed
gewarren
gewarren reviewed Oct 7, 2022
View reviewed changes
src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/Environments.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.Abstractions/src/IHostLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.Systemd/src/SystemdLifetime.cs Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs Outdated Show resolved Hide resolved
src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs Outdated Show resolved Hide resolved
Nick-Stanton and others added 2 commits October 7, 2022 11:39
@Nick-Stanton @gewarren
Apply suggestions from code review
a8832d3 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@Nick-Stanton
Resolve feedback to match conventions
ab88125
gewarren
gewarren approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src/WindowsServiceLifetime.cs Outdated Show resolved Hide resolved
@carlossanlop carlossanlop changed the title API Dept - Microsoft.Extensions.Hosting API Debt - Microsoft.Extensions.Hosting Oct 10, 2022
@build-analysis build-analysis bot mentioned this pull request Oct 11, 2022
Closed
2 tasks
@Nick-Stanton @gewarren
Update src/libraries/Microsoft.Extensions.Hosting.WindowsServices/src…
5a7753b 
…/WindowsServiceLifetime.cs

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
This was referenced Oct 11, 2022
Closed
Closed
Closed
@Nick-Stanton Nick-Stanton merged commit 2eee1ca into dotnet:main Oct 14, 2022
@Nick-Stanton Nick-Stanton deleted the APIDebtHosting branch October 14, 2022 21:46
@ghost ghost locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maryamariyan maryamariyan maryamariyan left review comments

@eerhardt eerhardt eerhardt left review comments

@tarekgh tarekgh tarekgh approved these changes

@gewarren gewarren gewarren approved these changes

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

Assignees

@Nick-Stanton Nick-Stanton

Labels
area-Extensions-Hosting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API documentation debt - Microsoft.Extensions.Hosting
5 participants
@Nick-Stanton @maryamariyan @eerhardt @tarekgh @gewarren