Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Update to latest .NET 7 Roslyn compiler #76471

Merged
merged 6 commits into from
Oct 4, 2022

Conversation

jaredpar
Copy link
Member

This is a back port of #76459.

The back port command failde due to merge conflicts hence this was created manually.

cston and others added 4 commits September 30, 2022 15:12
dotnet/roslyn#64093

This change enforced that `scoped` on a local set the escape scope to
the current block where previously it was incorrectly setting to the
containing method.
dotnet/roslyn#64318

This change allows anything returnable from a method to be assigned to
an `out` parameter. In several places had to add `scoped` to `ref` to
inform compiler they could not be captured in an `out` parameter.
dotnet/roslyn#64294

Compiler now issues warnings for pointer operations involving managed
types
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned jaredpar Sep 30, 2022
@jkotas jkotas changed the title Update to latest .NET 7 Roslyn compiler [release/7.0] Update to latest .NET 7 Roslyn compiler Sep 30, 2022
@ghost
Copy link

ghost commented Sep 30, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a back port of #76459.

The back port command failde due to merge conflicts hence this was created manually.

Author: jaredpar
Assignees: jaredpar
Labels:

area-Meta

Milestone: -

@carlossanlop
Copy link
Member

@jaredpar when/if this PR is ready, please request a code review sign-off, add the usual template descriptions (customer impact, testing, risks), apply the servicing-consider label, and email Tactics requesting approval.

@jaredpar
Copy link
Member Author

@carlossanlop .NET tactics has approved this change as it's follow up from compiler changes that went through approval. The need for this was asserted in the discussion and approved (assuming runtime had no push back on the changes).

please request a code review sign-off,

How do I request sign off?

@carlossanlop
Copy link
Member

It's usually the same folks who review the PR in main. So far, I see @stephentoub.

@jaredpar
Copy link
Member Author

jaredpar commented Sep 30, 2022

.NET tactics has approved this change as it's follow up from compiler changes that went through approval

BTW: this is a general policy going forward. Source build is now in sync with our product ship. That means whenever we make a toolset change, of which compiler is most prominent, that requires a code / build change in one of our repositories we must follow through with that change in impacted repositories. Failing to do so means source build cannot ship. Now when we take changes through .NET Tactics which we suspect will have downstream repo impact we get approval for both the toolset changes and the downstream repo change as a pair. During discussion we try and keep all three parties (toolset, repo owners and source build) involved. Happy to include anyone else to make sure things like this are well known as we take them for approval. 😄

@carlossanlop
Copy link
Member

.NET tactics has approved this change as it's follow up from compiler changes that went through approval. The need for this was asserted in the discussion and approved (assuming runtime had no push back on the changes).

Alright, so based on this, I'll apply the servicing-approved label. We only need someone else to sign-off.

@carlossanlop carlossanlop added the Servicing-approved Approved for servicing release label Oct 3, 2022
@jaredpar
Copy link
Member Author

jaredpar commented Oct 3, 2022

@stephentoub can you sign off on the backport of the change to release/7.0?

@carlossanlop
Copy link
Member

CI green, signed off, approved by Tactics. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 6bcb45f into dotnet:release/7.0 Oct 4, 2022
@carlossanlop carlossanlop added this to the 7.0.0 milestone Oct 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants