Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Do not run DynamicGenerics on mac (#74618) #76223

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Sep 27, 2022

Test-only change. Port #74618 to release/7.0.

Disabling intermittently failing native AOT test for macOS. macOS is not supported native aot platform for .NET 7.0.

Fixes #73299

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned jkotas Sep 27, 2022
@jkotas jkotas changed the title Do not run DynamicGenerics on mac (#74618) [release/7.0] Do not run DynamicGenerics on mac (#74618) Sep 27, 2022
@jkotas jkotas added area-NativeAOT-coreclr Servicing-consider Issue for next servicing release review labels Sep 27, 2022
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@jeffschwMSFT jeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Sep 27, 2022
@jeffschwMSFT
Copy link
Member

@jkotas can you take a look at the ci failures? We can merge as this is tell mode once ready.

@jkotas
Copy link
Member Author

jkotas commented Sep 27, 2022

The CI failures are #74328 / #75429

Ready to be merged.

@JulieLeeMSFT
Copy link
Member

@carlossanlop

Ready to be merged.

@carlossanlop
Copy link
Member

:shipit:

@carlossanlop carlossanlop merged commit f78dfdb into dotnet:release/7.0 Sep 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 27, 2022
@jkotas jkotas deleted the fix-73299 branch November 5, 2022 03:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants