Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Add workaround for msbuild issue in tests #76090

Merged
merged 4 commits into from
Sep 24, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 23, 2022

Backport of #75743 to release/7.0

/cc @lewing @radical

Customer Impact

may resolve #74328 and #75391 in CI

Testing

Intermittent build failure

Risk

CI infrastructure workaround

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

.. which causes it to crash. The issue is described in
dotnet/sdk#26965 besides other issues.

This can be removed once the sdk has a fix for this.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 23, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75743 to release/7.0

/cc @lewing @radical

Customer Impact

may resolve #74328 and #75391 in CI

Testing

Intermittent build failure

Risk

CI infrastructure workaround

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure

Milestone: -

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs the wasm legs to be triggered additionally, correct? Or do they run automatically?

@carlossanlop
Copy link
Member

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Sep 23, 2022

coreclr failure is #74488

@lewing
Copy link
Member

lewing commented Sep 23, 2022

wasm failure is #74302 probably not but it is a timeout in the test run not the build so not related to this change and the failure is in the library tests of System.Runtime not the special runtime tests mentioned in the linked issue

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-76090-merge-f53f7162d92744a59d/WasmTestOnBrowser-System.Runtime.Tests/1/console.4f411128.log?helixlogtype=result

ChromeDriver was started successfully.
[22:18:02] info: Incoming arguments: --run WasmTestRunner.dll System.Runtime.Tests.dll -notrait category=AdditionalTimezoneChecks -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
[22:18:02] info: Application arguments: --run WasmTestRunner.dll System.Runtime.Tests.dll -notrait category=AdditionalTimezoneChecks -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
[22:18:02] info: browser: [main] Console websocket connected.
[22:18:38] info: Initializing.....
[22:18:38] info: Discovering: System.Runtime.Tests.dll (method display = ClassAndMethod, method display options = None)
[22:18:43] info: Discovered:  System.Runtime.Tests.dll (found 8917 of 9067 test cases)
[22:18:43] info: Using random seed for test cases: 2021412321
[22:18:43] info: Using random seed for collections: 2021412321
[22:18:43] info: Starting:    System.Runtime.Tests.dll

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 3600 seconds and was killed

['WasmTestOnBrowser-System.Runtime.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@lewing
Copy link
Member

lewing commented Sep 23, 2022

@carlossanlop I restarted the builds and opened #76110 for the wasm hang, merge as you please

@lewing
Copy link
Member

lewing commented Sep 24, 2022

now it is #74302 and they might be the same

@lewing lewing merged commit 87f8d0a into release/7.0 Sep 24, 2022
@lewing lewing deleted the backport/pr-75743-to-release/7.0 branch September 24, 2022 02:33
@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants