Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Console.SetWindowSize() for linux #75824

Merged
merged 12 commits into from
Nov 8, 2022
Merged

Implement Console.SetWindowSize() for linux #75824

merged 12 commits into from
Nov 8, 2022

Commits on Oct 31, 2022

  1. Impl Console.SetWindowSize() for linux

    @HJLeee
    HJLeee committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    f4f028b View commit details
    Browse the repository at this point in the history

  2. Apply Feedback 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Michał Petryka <35800402+MichalPetryka@users.noreply.github.com>
    @HJLeee @stephentoub @MichalPetryka
    3 people committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    24b0083 View commit details
    Browse the repository at this point in the history

  3. Throw IOException if fail

    @HJLeee
    HJLeee committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    324b31b View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @HJLeee @adamsitnik
    HJLeee and adamsitnik committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    814d5c0 View commit details
    Browse the repository at this point in the history

  5. Add supportplatform freebsd & osx

    @HJLeee
    HJLeee committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    e8fd3ac View commit details
    Browse the repository at this point in the history

  6. Enable SetWindowSize_GetWindowSize_ReturnsExpected

    @HJLeee
    HJLeee committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    3379de1 View commit details
    Browse the repository at this point in the history

  7. add manual test

    @adamsitnik @HJLeee
    adamsitnik authored and HJLeee committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    ee31937 View commit details
    Browse the repository at this point in the history

  8. Remove note in ArgumentOutOfRangeException 

    Co-authored-by: Dan Moseley <danmose@microsoft.com>
    @HJLeee @danmoseley
    HJLeee and danmoseley committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    4591a93 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Update src/libraries/System.Console/tests/ManualTests/ManualTests.cs 

    Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
    @HJLeee @adamsitnik
    HJLeee and adamsitnik committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e315d16 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    @HJLeee @stephentoub
    HJLeee and stephentoub committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    b616914 View commit details
    Browse the repository at this point in the history

  2. Cleanup SupportOSPlatfromAttributes

    @HJLeee
    HJLeee committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    3cff6cb View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. Update APICompat annotations

    @adamsitnik
    adamsitnik committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    e641300 View commit details
    Browse the repository at this point in the history