Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove explicit LangVersion from a few projects #75806

Merged
merged 4 commits into from
Sep 29, 2022
Merged

remove explicit LangVersion from a few projects #75806

merged 4 commits into from
Sep 29, 2022

Conversation

kasperk81
Copy link
Contributor

No description provided.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 18, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 18, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: kasperk81
Assignees: -
Labels:

area-Infrastructure-libraries, community-contribution
Milestone: -

@kasperk81 kasperk81 closed this Sep 19, 2022
@kasperk81 kasperk81 reopened this Sep 19, 2022
@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 19, 2022 •
edited
Loading

This one can be removed as well:

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System.Diagnostics.DiagnosticSource.csproj

Line 10 in 16cb35f

<LangVersion Condition="'$(TargetFramework)' == 'net6.0'">10</LangVersion>

@ViktorHofer
Copy link
Member

As explained here it can be removed now.

@kasperk81
Copy link
Contributor Author

all checks passed

@kasperk81 kasperk81 closed this Sep 20, 2022
@kasperk81 kasperk81 reopened this Sep 20, 2022
@runfoapp runfoapp bot mentioned this pull request Sep 20, 2022
Open
@kasperk81 kasperk81 closed this Sep 21, 2022
@kasperk81 kasperk81 reopened this Sep 21, 2022
@ViktorHofer
Copy link
Member

Thanks a lot. Great work!

@kasperk81
Copy link
Contributor Author

@ViktorHofer looks good to merge?

@ViktorHofer ViktorHofer merged commit 08d0bd9 into dotnet:main Sep 29, 2022
@ViktorHofer
Copy link
Member

Thanks a lot

@kasperk81 kasperk81 mentioned this pull request Oct 15, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-libraries community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperk81 @ViktorHofer @marek-safar