Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] hide interop delegates from intellisense #75800

Merged
merged 1 commit into from
Sep 19, 2022
Merged

[wasm] hide interop delegates from intellisense #75800

merged 1 commit into from
Sep 19, 2022

Conversation

pavelsavara
Copy link
Member

There are delegate types ArgumentToManagedCallback<> and ArgumentToJSCallback<> which are used by Roslyn code generator of the JavaScript interop.

They are not intended to be used directly by the developer and we could hide them from intellisense.

Related discussion dotnet/dotnet-api-docs#8392 (comment)

@pavelsavara pavelsavara added this to the 8.0.0 milestone Sep 17, 2022
@pavelsavara pavelsavara self-assigned this Sep 17, 2022
@ghost
Copy link

ghost commented Sep 17, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

There are delegate types ArgumentToManagedCallback<> and ArgumentToJSCallback<> which are used by Roslyn code generator of the JavaScript interop.

They are not intended to be used directly by the developer and we could hide them from intellisense.

Related discussion dotnet/dotnet-api-docs#8392 (comment)

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@pavelsavara pavelsavara mentioned this pull request Sep 17, 2022
Merged
gewarren
gewarren approved these changes Sep 18, 2022
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavelsavara
Copy link
Member Author

Build error is unrelated.

@pavelsavara pavelsavara merged commit 16cb35f into dotnet:main Sep 19, 2022
@pavelsavara
Copy link
Member Author

/backport to release/7.0-rc2

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc2: https://github.com/dotnet/runtime/actions/runs/3080462553

@github-actions github-actions bot mentioned this pull request Sep 19, 2022
Merged
@pavelsavara pavelsavara deleted the wasm_hide_interop_delegates branch October 13, 2022 10:04
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gewarren gewarren gewarren approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @gewarren