Make ResourceManager.BaseName work as documented.

[madelson]

This property is documented to return the "qualified namespace name and the root resource name of a resource file". However, previously when constructing a ResourceManager with a Type the BaseName property would instead return the name of the type without its namespace.

fix #74918

[ghost]

Tagging subscribers to this area: @dotnet/area-system-resources
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This property is documented to return the "qualified namespace name and the root resource name of a resource file". However, previously when constructing a ResourceManager with a Type the BaseName property would instead return the name of the type without its namespace.

fix #74918

Author:	madelson
Assignees:	-
Labels:	area-System.Resources
Milestone:	-

[joperezr]

Sorry for taking a while to look at this, thanks for the contribution!

Could you also please add more tests that ensure the right behavior of BaseName? For example, can you add one where the type doesn't have a namespace too?

[madelson]

@joperezr any other test cases you'd like to see?

[buyaa-n]

Thanks for the fix @madelson, but it might be not a bug needs a fix, see my comment on the issue for details, we might need to clarify the doc instead, I will dig into it more

Also there is existing test that specifically checking this scenario is failing on CI

 System.ComponentModel.Tests.ComponentResourceManagerTests.Ctor_Type(type: typeof(int)) [FAIL]
      Assert.Equal() Failure
                ↓ (pos 0)
      Expected: Int32
      Actual:   System.Int32
                ↑ (pos 0)
      Stack Trace:
        /_/src/libraries/System.ComponentModel.TypeConverter/tests/ComponentResourceManagerTests.cs(27,0): at System.ComponentModel.Tests.ComponentResourceManagerTests.Ctor_Type(Type type)
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(69,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
  Finished:    System.ComponentModel.TypeConverter.Tests
=== TEST EXECUTION SUMMARY ===
   System.ComponentModel.TypeConverter.Tests  Total: 7825, Errors: 0, Failed: 1, Skipped: 0, Time: 32.183s

[madelson]

Thanks for engaging @buyaa-n . I'll fix that test if we decide to proceed with this change.

[buyaa-n]

Thanks for engaging @buyaa-n . I'll fix that test if we decide to proceed with this change.

Please do that so that we can see if any other test fails

[madelson]

Please do that so that we can see if any other test fails

@buyaa-n pushed the fix!

[buyaa-n]

Overall LGTM, thanks @madelson