Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Pass resource items for VS generated authoring #75461

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #75454 to release/7.0

/cc @lewing @joeloff

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 12, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75454 to release/7.0

/cc @lewing @joeloff

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@ghost
Copy link

ghost commented Sep 12, 2022

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75454 to release/7.0

/cc @lewing @joeloff

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-mono, area-System.Data.OleDB

Milestone: -

@carlossanlop
Copy link
Member

@joeloff there was an installer failure. I opened this issue #75491. Can you please confirm if it is related to this change or not?

These failures are unrelated:

  • Brotli, Globalization and OleDB failures were an abrupt exit of the executor:
['System.IO.Compression.Brotli.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]
['System.Data.OleDb.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]
['System.Globalization.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

@lewing
Copy link
Member

lewing commented Sep 12, 2022

There are some very strange failures here

@joeloff there was an installer failure. I opened this issue #75491. Can you please confirm if it is related to this change or not?

These failures are unrelated:

  • Brotli, Globalization and OleDB failures were an abrupt exit of the executor:
['System.IO.Compression.Brotli.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]
['System.Data.OleDb.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]
['System.Globalization.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

Not related

@lewing
Copy link
Member

lewing commented Sep 12, 2022

This is also part of the tell-mode workload stuff

@lewing
Copy link
Member

lewing commented Sep 12, 2022

mono failure is also not related.

/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: System.IO.Compression.Brotli.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.IO.Compression.Brotli.Tests (found 69 of 81 test cases)
  Starting:    System.IO.Compression.Brotli.Tests (parallel test collections = on, max threads = 2)

...
[EXECUTION TIMED OUT]
Exit Code:-3Executor timed out after 900 seconds and was killed
['System.IO.Compression.Brotli.Tests' END OF WORK ITEM LOG: Command timed out, and was killed]

These timeouts might be infrastructure problems.

@carlossanlop
Copy link
Member

Thanks for checking, @lewing. Merging.

@carlossanlop carlossanlop merged commit 13bd76a into release/7.0 Sep 13, 2022
@carlossanlop carlossanlop deleted the backport/pr-75454-to-release/7.0 branch September 13, 2022 01:08
lewing added a commit that referenced this pull request Sep 13, 2022
carlossanlop pushed a commit that referenced this pull request Sep 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants