Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[mono][llvm] Disable simd intrinsics when we might be interop… #75438

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Revert "[mono][llvm] Disable simd intrinsics when we might be interop… #75438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/mono/mono/mini/mini.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3027,7 +3027,7 @@ static gboolean
is_simd_supported (MonoCompile *cfg)
{
#ifdef DISABLE_SIMD
return FALSE;
return FALSE;
#endif
// FIXME: Clean this up
#ifdef TARGET_WASM
Expand All @@ -3036,10 +3036,6 @@ is_simd_supported (MonoCompile *cfg)
#else
if (cfg->llvm_only)
return FALSE;
// FIXME We disable simd intrinsics when mixing between llvmaot and jit since the llvm backend could
// see that certain simd operations are supported while with jit we fail to emit correct code.
if (cfg->compile_aot && cfg->compile_llvm && !cfg->full_aot)
return FALSE;
#endif
return TRUE;
}
Expand Down
6 changes: 6 additions & 0 deletions src/mono/mono/mini/simd-intrinsics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -719,6 +719,12 @@ emit_hardware_intrinsics (
goto support_probe_complete;
id = info->id;

#ifdef TARGET_ARM64
if (!(cfg->compile_aot && cfg->full_aot && !cfg->interp) && !intrin_group->jit_supported) {
goto support_probe_complete;
}
#endif

// Hardware intrinsics are LLVM-only.
if (!COMPILE_LLVM (cfg) && !intrin_group->jit_supported)
goto support_probe_complete;
Expand Down