Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude segment_standby_list from regions #74975

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

cshung
Copy link
Member

@cshung cshung commented Sep 2, 2022

No description provided.

@cshung cshung self-assigned this Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr

Milestone: -

@Maoni0
Copy link
Member

Maoni0 commented Sep 7, 2022

in get_segment could you please also get rid of this check -

#ifdef USE_REGIONS

since get_segment is only defined when USE_REGIONS is not.


Refers to: src/coreclr/gc/gc.cpp:5756 in c6cb320. [](commit_id = c6cb320, deletion_comment = False)


In reply to: 1239860737

@Maoni0
Copy link
Member

Maoni0 commented Sep 7, 2022

        // this needs be serialized just because we have one

can you please also get rid of this comment? it's not applicable.


In reply to: 1239876205


Refers to: src/coreclr/gc/gc.cpp:30418 in c6cb320. [](commit_id = c6cb320, deletion_comment = False)

Copy link
Member

@Maoni0 Maoni0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than my comments it LGTM. feel free to merge this since this is not specific to the low memory stuff you are working on right now.

@cshung cshung merged commit 31bdc77 into dotnet:main Sep 8, 2022
@cshung cshung deleted the public/exclude-segment-standby-list branch September 8, 2022 02:33
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants